jerqi commented on code in PR #1652:
URL:
https://github.com/apache/incubator-uniffle/pull/1652#discussion_r1582487182
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java:
##########
@@ -127,19 +127,18 @@ public WriteBufferManager(
long taskAttemptId,
BufferManagerOptions bufferManagerOptions,
Serializer serializer,
- Map<Integer, List<ShuffleServerInfo>> partitionToServers,
TaskMemoryManager taskMemoryManager,
ShuffleWriteMetrics shuffleWriteMetrics,
RssConf rssConf,
- Function<List<ShuffleBlockInfo>, List<CompletableFuture<Long>>>
spillFunc) {
+ Function<List<ShuffleBlockInfo>, List<CompletableFuture<Long>>>
spillFunc,
+ Function<Integer, List<ShuffleServerInfo>>
partitionAssignmentRetrieveFunc) {
Review Comment:
If we use func, we should limit the situation.
1. We don't want to pass some weird or coupled parameters to this method.
2. This behavior can vary from different caller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
