jerqi commented on PR #1652: URL: https://github.com/apache/incubator-uniffle/pull/1652#issuecomment-2082304407
> It looks there was agreement on the regular partition reassignment, that's good. > > Let's extending the topic to huge partition or high-load server that you defined. > > > Could we return a high load error code to the server when the shuffle server has too high load? Is it a failure when we just return a high load error code? > > Yes. this is OK. Actually this could be implemented in shuffle-server side. And All need things for this high-load reassignment have been supported in client side. > > > Maybe we don't need to change this class name. Should we have a strategy class to handle the difference between faulty servers and high load servers. > > Yes. this also could be implemented in TaskAssignment side, actually this has been supported in the pervious implementation but for better understand, I removed this part. > > Anyway, I only do the regular reassignment here and ensure the expansibility for future development 1. I just feel that receivingFailureServer isn't a good name. 2. Could you extract some strategies classes for different ways? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
