zuston commented on code in PR #1652: URL: https://github.com/apache/incubator-uniffle/pull/1652#discussion_r1584075206
########## client-spark/common/src/main/java/org/apache/spark/shuffle/writer/TaskAttemptAssignment.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.shuffle.writer; + +import java.util.List; +import java.util.Map; + +import org.apache.spark.shuffle.handle.MutableShuffleHandleInfo; +import org.apache.spark.shuffle.handle.ShuffleHandleInfo; + +import org.apache.uniffle.common.ShuffleServerInfo; +import org.apache.uniffle.common.exception.RssException; + +/** This class is to get the partition assignment for ShuffleWriter. */ +public class TaskAttemptAssignment { + private Map<Integer, List<ShuffleServerInfo>> assignment; + private boolean mutable = false; + + public TaskAttemptAssignment(long taskAttemptId, ShuffleHandleInfo shuffleHandleInfo) { + this.assignment = shuffleHandleInfo.getAvailablePartitionServersForWriter(); + if (shuffleHandleInfo instanceof MutableShuffleHandleInfo) { + this.mutable = true; + } + } + + public List<ShuffleServerInfo> retrieve(int partitionId) { Review Comment: This just invokes the ShuffleHandleInfo interface. But for loadbalance feature, I haven't think the clear interface. So let's ignore this part about loadbalance here. And I want to clarity that the return value of `List<ShuffleServerInfo>` is the multiple replica servers, it's not a faultyServer + available servers. And I think this should be wrapped in another class but not in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
