xianjingfeng commented on code in PR #1685:
URL: 
https://github.com/apache/incubator-uniffle/pull/1685#discussion_r1595021361


##########
storage/src/main/java/org/apache/uniffle/storage/common/LocalStorage.java:
##########
@@ -270,6 +269,14 @@ public void updateDiskFree(long free) {
     this.diskFree = free;
   }
 
+  public void updateServiceUsed(long used) {

Review Comment:
   > BTW. What does `service` here mean? Do we have a better name?
   
   This variable means the total size of files written by this shuffle server 
instance. Do you have any good ideas?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to