xianjingfeng commented on code in PR #1685:
URL: 
https://github.com/apache/incubator-uniffle/pull/1685#discussion_r1595125304


##########
server/src/main/java/org/apache/uniffle/server/LocalStorageChecker.java:
##########
@@ -113,8 +113,9 @@ public boolean checkIsHealthy() {
 
                 totalSpace.addAndGet(total);
                 wholeDiskUsedSpace.addAndGet(total - free);
-                
serviceUsedSpace.addAndGet(getServiceUsedSpace(storageInfo.storageDir));
-
+                long usedBytes = getServiceUsedSpace(storageInfo.storageDir);
+                serviceUsedSpace.addAndGet(usedBytes);

Review Comment:
   If we unify them, it will bring too many changes. I think we can do this by 
another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to