zuston commented on code in PR #1677:
URL:
https://github.com/apache/incubator-uniffle/pull/1677#discussion_r1596203273
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -810,25 +823,31 @@ private ShuffleManagerClient
createShuffleManagerClient(String host, int port) {
.createShuffleManagerClient(ClientType.GRPC, host, port);
}
+ private ShuffleManagerClient getOrCreateShuffleManagerClient() {
Review Comment:
Won't. The client will be initialized in this class constructor.
##########
integration-test/spark3/src/test/java/org/apache/uniffle/test/ContinuousSelectPartitionStrategyTest.java:
##########
@@ -238,8 +239,12 @@ public int compare(String o1, String o2) {
// Validate getShuffleResultForMultiPart is correct before return result
ClientType clientType =
ClientType.valueOf(spark.sparkContext().getConf().get(RssSparkConfig.RSS_CLIENT_TYPE));
- if (ClientType.GRPC == clientType) {
+ boolean blockIdSelfManagedEnabled =
+ RssSparkConfig.toRssConf(spark.sparkContext().getConf())
+ .get(RSS_CLIENT_BLOCK_ID_SELF_MANAGED_ENABLED);
+ if (ClientType.GRPC == clientType && !blockIdSelfManagedEnabled) {
// TODO skip validating for GRPC_NETTY, needs to mock
ShuffleServerNettyHandler
+ // TODO: skip validating when blockId is managed in spark driver side.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
