zuston commented on code in PR #1677:
URL:
https://github.com/apache/incubator-uniffle/pull/1677#discussion_r1596217907
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -37,6 +37,12 @@
public class RssSparkConfig {
+ public static final ConfigOption<Boolean>
RSS_CLIENT_BLOCK_ID_SELF_MANAGED_ENABLED =
+ ConfigOptions.key("rss.client.blockId.selfManagedEnabled")
Review Comment:
> Maybe we should remove client word to align other blockId config options.
Done
> Except, I'm a little worried about the config options about Uniffle.
Because there are some less elegant issues. client seems extra. Don't use camel
style. Proper segments.
This could be optimized because we have the discard mechanism in
configOption, that need to be detailed in doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
