zuston commented on code in PR #1712:
URL:
https://github.com/apache/incubator-uniffle/pull/1712#discussion_r1606212747
##########
common/src/main/java/org/apache/uniffle/common/ReconfigurableConfManager.java:
##########
@@ -0,0 +1,53 @@
+package org.apache.uniffle.common;
+
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.uniffle.common.config.ConfigOption;
+import org.apache.uniffle.common.config.RssBaseConf;
+import org.apache.uniffle.common.config.RssConf;
+import org.apache.uniffle.common.util.ThreadUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ReconfigurableConfManager {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(ReconfigurableConfManager.class);
+
+ private static RssBaseConf rssConf;
+ private ScheduledExecutorService scheduledThreadPoolExecutor;
+
+ private ReconfigurableConfManager(Supplier<RssBaseConf> confSupplier) {
+ rssConf = confSupplier.get();
+ scheduledThreadPoolExecutor =
ThreadUtils.getDaemonSingleThreadScheduledExecutor("Refresh-rss-conf");
+ scheduledThreadPoolExecutor.schedule(() -> {
+ try {
+ rssConf.addAll(confSupplier.get());
Review Comment:
Yes. This could be logged of changed for better user experience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
