jerqi commented on code in PR #1712:
URL:
https://github.com/apache/incubator-uniffle/pull/1712#discussion_r1609430288
##########
common/src/main/java/org/apache/uniffle/common/config/RssConf.java:
##########
@@ -569,7 +573,7 @@ public <T> RssConf set(ConfigOption<T> option, T value) {
return this;
}
- <T> void setValueInternal(String key, T value) {
+ public <T> void setValueInternal(String key, T value) {
Review Comment:
This method should be used in the class inner from the name. Could we avoid
using it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
