rickyma commented on code in PR #1730:
URL:
https://github.com/apache/incubator-uniffle/pull/1730#discussion_r1609207851
##########
pom.xml:
##########
@@ -921,6 +921,7 @@
<java.io.tmpdir>${project.build.directory}/tmp</java.io.tmpdir>
<project.version>${project.version}</project.version>
<jacoco-agent.destfile>target/jacoco.exec</jacoco-agent.destfile>
+ <test.mode>true</test.mode>
Review Comment:
Since `RssUtils#getHostIp` is a method in a utility class and does not
accept any input parameters, we can only use environment variables to inform
the internal logic that the unit test is being executed. This approach requires
the least amount of changes and is the most reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
