rickyma commented on code in PR #1730:
URL:
https://github.com/apache/incubator-uniffle/pull/1730#discussion_r1609344778
##########
pom.xml:
##########
@@ -921,6 +921,7 @@
<java.io.tmpdir>${project.build.directory}/tmp</java.io.tmpdir>
<project.version>${project.version}</project.version>
<jacoco-agent.destfile>target/jacoco.exec</jacoco-agent.destfile>
+ <test.mode>true</test.mode>
Review Comment:
When running unit tests, they are executed on a single machine and do not
interact with other machines. Therefore, unit tests should not require a valid
broadcast IP address. Currently, we do not support scenarios where the
broadcast IP address of the host machine is 0.0.0.0. I think this is an
unreasonable limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
