zuston commented on code in PR #1758:
URL:
https://github.com/apache/incubator-uniffle/pull/1758#discussion_r1620482339
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -413,8 +413,14 @@ public void addFinishedBlockIds(
+ " bitmaps!");
}
+ ShuffleTaskInfo taskInfo = getShuffleTaskInfo(appId);
+ if (taskInfo == null) {
+ throw new InvalidRequestException(
+ "ShuffleTaskInfo is not found that should not happen for appId: " +
appId);
+ }
for (Map.Entry<Integer, long[]> entry : partitionToBlockIds.entrySet()) {
Integer partitionId = entry.getKey();
+ taskInfo.incrBlockNumber(shuffleId, partitionId,
entry.getValue().length);
Review Comment:
If the blockId exists in the bitmap, the blockId counter increment will be
ignored. This may need to log if having any duplicate blockId occur
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
