jerqi commented on code in PR #1758:
URL:
https://github.com/apache/incubator-uniffle/pull/1758#discussion_r1621864810
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -506,14 +506,23 @@ public void reportShuffleResult(
"appId[" + appId + "], shuffleId[" + shuffleId + "], taskAttemptId[" +
taskAttemptId + "]";
try {
+ int expected = partitionToBlockIds.values().stream().mapToInt(x ->
x.length).sum();
LOG.info(
- "Report "
- + partitionToBlockIds.size()
- + " blocks as shuffle result for the task of "
- + requestInfo);
- shuffleServer
- .getShuffleTaskManager()
- .addFinishedBlockIds(appId, shuffleId, partitionToBlockIds,
bitmapNum);
+ "Accepted blockIds report for {} blocks across {} partitions as
shuffle result for task {}",
+ expected,
+ partitionToBlockIds.size(),
+ request);
+ int updated =
+ shuffleServer
+ .getShuffleTaskManager()
+ .addFinishedBlockIds(appId, shuffleId, partitionToBlockIds,
bitmapNum);
+ if (expected != updated) {
Review Comment:
`expected` -> `expectedBlockCount`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
