xianjingfeng commented on code in PR #1763:
URL: 
https://github.com/apache/incubator-uniffle/pull/1763#discussion_r1627030219


##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -422,6 +423,12 @@ public class ShuffleServerConf extends RssBaseConf {
               "The interval of trigger shuffle buffer manager to flush data to 
persistent storage. If <= 0"
                   + ", then this flush check would be disabled.");
 
+  public static final ConfigOption<ShuffleBufferType> 
SERVER_SHUFFLE_BUFFER_TYPE =

Review Comment:
   > If we can always achieve good results, why do we still need this switch?
   
   The `slow start` feature of MR requires that the order of blocks can't be 
changed. 
https://github.com/apache/incubator-uniffle/issues/1708#issuecomment-2117233393



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to