rickyma commented on code in PR #1763:
URL:
https://github.com/apache/incubator-uniffle/pull/1763#discussion_r1627068192
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -426,8 +426,11 @@ public class ShuffleServerConf extends RssBaseConf {
public static final ConfigOption<ShuffleBufferType>
SERVER_SHUFFLE_BUFFER_TYPE =
ConfigOptions.key("rss.server.shuffleBuffer.type")
.enumType(ShuffleBufferType.class)
- .defaultValue(ShuffleBufferType.NONE)
- .withDescription("The type for shuffle buffers.");
+ .defaultValue(ShuffleBufferType.LINKED_LIST)
+ .withDescription(
+ "The type for shuffle buffers. Setting as LINKED_LIST or
SKIP_LIST."
+ + "The default value is LINKED_LIST. SKIP_LIST will help to
improve"
+ + "the performance, but it don't support the show start
feature of MR");
Review Comment:
In which scenarios can performance be improved? Or is it to say that
performance can be improved in all scenarios except for MR with slow-start
feature on? Could you please describe it in more detail?
it don't support the show start feature of MR
->
it doesn't support the slow-start feature of MR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
