zhengchenyu commented on code in PR #1418:
URL:
https://github.com/apache/incubator-uniffle/pull/1418#discussion_r1630563911
##########
common/src/main/java/org/apache/uniffle/common/util/BlockIdLayout.java:
##########
@@ -143,7 +143,7 @@ public int hashCode() {
return Objects.hash(sequenceNoBits, partitionIdBits, taskAttemptIdBits);
}
- public long getBlockId(int sequenceNo, int partitionId, long taskAttemptId) {
+ public long getBlockId(int sequenceNo, int partitionId, int taskAttemptId) {
Review Comment:
@EnricoMi
I don't know why taskAttemptId is long? Since we have restricted
taskAttemptIdBits to never greater than 32 bits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
