zhengchenyu commented on code in PR #1418:
URL:
https://github.com/apache/incubator-uniffle/pull/1418#discussion_r1630570613
##########
client-mr/core/src/main/java/org/apache/hadoop/mapred/SortWriteBufferManager.java:
##########
@@ -64,7 +64,7 @@ public class SortWriteBufferManager<K, V> {
private final Counters.Counter mapOutputRecordCounter;
private long uncompressedDataLen = 0;
private long compressTime = 0;
- private final long taskAttemptId;
+ private final int taskAttemptId;
Review Comment:
@EnricoMi
I think the original taskattemptid is long because it comes from
TaskContext::taskAttemptId of spark, which is the unique id of attempt at the
app level. MR and Tez inherited the long type, but implemented taskattemptid by
bit concatenation of taskid and attemptid in this task.
I think you have changed taskattemptid to the concatenation of taskid and
attemptid in #731, and limited it to no more than 32 bits, so int is enough.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
