yl09099 commented on code in PR #1449: URL: https://github.com/apache/incubator-uniffle/pull/1449#discussion_r1634628080
########## dashboard/src/main/java/org/apache/uniffle/dashboard/web/resource/Response.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.uniffle.dashboard.web.resource; + +public class Response<T> { Review Comment: > > Could we move it to the common module? And the same class in the coordinator module. > > This Response is in the Coordinator module. The Coordinator module is introduced into the dashboard here, which feels a bit awkward. Just like you said, it needs to be migrated to the common module, but I don't think it should be done in this PR. I'm introducing front-end code inspection to change this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
