rickyma commented on code in PR #1449:
URL:
https://github.com/apache/incubator-uniffle/pull/1449#discussion_r1634727835
##########
dashboard/src/main/webapp/src/api/api.js:
##########
@@ -77,6 +77,6 @@ export function getTotalForUser(params,headers) {
}
// Obtain the configured coordinator server list
-export function getAllCoordinatorAddrees(params) {
- return http.get('/coordinator/coordinatorList', params, {}, 1)
+export function getAllCoordinatorAddrees(params,headers) {
+ return http.get('/coordinator/coordinators', params, headers, 1)
Review Comment:
This is a little bit weird.
The RESTful style should be something like:
/plural noun
/plural noun/id
e.g.
/coordinators
/coordinators/1
You can refer to
https://blog.restcase.com/5-basic-rest-api-design-guidelines/.
I don't know if it is convenient for you to refactor this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
