EnricoMi commented on code in PR #1753:
URL:
https://github.com/apache/incubator-uniffle/pull/1753#discussion_r1637956477
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java:
##########
@@ -259,12 +262,13 @@ public void write(Iterator<Product2<K, V>> records) {
if (shuffleManager.isRssResubmitStage()) {
throwFetchFailedIfNecessary(e);
} else {
- throw e;
+ throw new RssException(e);
}
}
}
- private void writeImpl(Iterator<Product2<K, V>> records) {
+ // gluten need this method and IOException must be throws here
Review Comment:
> Implementations of this method can catch any `IOException` and rethrow a
`new RssException(e)`, this would keep the interface clean.
@xianjingfeng I did not mean to add that as a comment but to apply this to
your gluten client implementation. There is no need for this method to
specifically throw an `IOException`, simply throw an `RssException` inside your
implementation of `writeImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
