EnricoMi commented on code in PR #1753:
URL:
https://github.com/apache/incubator-uniffle/pull/1753#discussion_r1641908661
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java:
##########
@@ -259,12 +262,13 @@ public void write(Iterator<Product2<K, V>> records) {
if (shuffleManager.isRssResubmitStage()) {
throwFetchFailedIfNecessary(e);
} else {
- throw e;
+ throw new RssException(e);
}
}
}
- private void writeImpl(Iterator<Product2<K, V>> records) {
+ // gluten need this method and IOException must be throws here
Review Comment:
Can you change the [signature of `writeImpl` in
gluten](https://github.com/apache/incubator-gluten/blob/fbb4ec588b0d1ef88d179632de598ac77091367b/gluten-uniffle/velox/src/main/java/org/apache/spark/shuffle/writer/VeloxUniffleColumnarShuffleWriter.java#L127)
and have the next version of gluten work with Uniffle 0.9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
