wForget commented on PR #1822: URL: https://github.com/apache/incubator-uniffle/pull/1822#issuecomment-2185922687
> Why would `release` be called multiple times? I didn't find out why it was called multiple times in #1628. Apparently, in https://github.com/apache/incubator-uniffle/blob/1482804f3bd365adce9af251a0a71ca463928083/storage/src/main/java/org/apache/uniffle/storage/handler/impl/DataSkippableReadHandler.java#L72, it checks whether `shuffleIndexResult` is not empty. One of my guesses is that buffer is cleaned up when netty client is closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
