advancedxy commented on PR #1822: URL: https://github.com/apache/incubator-uniffle/pull/1822#issuecomment-2186358332
Hmm, I'm not sure about this change. If we can find the root cause why it's called multiple times and can reason that the multiple released is necessary, this change looks good to me. However, we have not find the root cause. By simply avoid/reset the managedBuffer to null, we may hide a bigger problem and causing more subtle problems later. Could we add more logging first to help debugging this issue? For example, we can log the double release in the releasing method with the stack trace? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
