advancedxy commented on code in PR #1835:
URL:
https://github.com/apache/incubator-uniffle/pull/1835#discussion_r1654817167
##########
.github/workflows/parallel.yml:
##########
@@ -105,3 +109,10 @@ jobs:
continue-on-error: true
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
+ - name: Upload test logs
Review Comment:
There's already a test reports upload in L103 - L108, we should consolidate
these two uploads.
And are you sure the test logs are uploaded? I didn't see any of them in the
summary or in the GH logs:
https://github.com/apache/incubator-uniffle/actions/runs/9673099296/job/26686511286?pr=1835
for example, the upload test logs step is skipped.
##########
.github/workflows/parallel.yml:
##########
@@ -105,3 +109,10 @@ jobs:
continue-on-error: true
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
+ - name: Upload test logs
+ if: failure()
+ uses: actions/upload-artifact@v3
+ with:
+ name: ${{ inputs.tests-name }}-log-${{ matrix.profile }}
+ path: |
Review Comment:
Nit: we may also want to set the `retention-days`, such as 7. Otherwise 90
days by default is too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
