xumanbu commented on code in PR #1838:
URL:
https://github.com/apache/incubator-uniffle/pull/1838#discussion_r1657155752
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -446,6 +446,7 @@ public <K, V> ShuffleWriter<K, V> getWriter(
this,
sparkConf,
shuffleWriteClient,
+ shuffleManagerClient,
Review Comment:
It's your original idea, but I discovered it already initialized in the
`RssShuffleManage` construct, so I simply addressed it.
Ok. I will attempt to implement a 'lazyShuffleManagerClient' instead of
'shuffleManagerClient'.
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -446,6 +446,7 @@ public <K, V> ShuffleWriter<K, V> getWriter(
this,
sparkConf,
shuffleWriteClient,
+ shuffleManagerClient,
Review Comment:
It's your original idea, but I discovered it already initialized in the
`RssShuffleManage` construct, so I simply addressed it.
Ok. I will attempt to implement a 'lazyShuffleManagerClient' instead of
'shuffleManagerClient' initialized in new `RssShuffleManage` at now.
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -446,6 +446,7 @@ public <K, V> ShuffleWriter<K, V> getWriter(
this,
sparkConf,
shuffleWriteClient,
+ shuffleManagerClient,
Review Comment:
Agree with u. my original idea is same with u, but I discovered it already
initialized in the `RssShuffleManage` construct, so I simply addressed it.
Ok. I will attempt to implement a `lazyShuffleManagerClient` instead of
`shuffleManagerClient` initialized in new `RssShuffleManage` at now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
