advancedxy commented on code in PR #1838:
URL:
https://github.com/apache/incubator-uniffle/pull/1838#discussion_r1665847030
##########
client-spark/common/src/main/java/org/apache/uniffle/shuffle/BlockIdSelfManagedShuffleWriteClient.java:
##########
@@ -73,7 +74,11 @@ public void reportShuffleResult(
RssReportShuffleResultRequest request =
new RssReportShuffleResultRequest(
appId, shuffleId, taskAttemptId, partitionToBlockIds, bitmapNum);
- shuffleManagerClient.reportShuffleResult(request);
+ AutoCloseWrapper.run(
Review Comment:
hmmm. This seems a bit of code smell here, I don't think we should introduce
such complex construct to simply delay the close of closeable. It brings the
burden of using `AutoCloseWrapper.run` on every invocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
