advancedxy commented on PR #1838: URL: https://github.com/apache/incubator-uniffle/pull/1838#issuecomment-2244672936
> > @xumanbu thanks for your hard work. I think it's in good shape and the right direction. > > The biggest issue is how to handle close from external caller for `ExpiringCloseableSupplier`. > > @advancedxy Very thank you for helping me review the code and for your valuable suggestions. I'm still a bit confused by some comments, I need think about more and optimize the code. You are welcome. And if you have any further questions or problems, feel free to ask here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
