rickyma commented on PR #1866: URL: https://github.com/apache/incubator-uniffle/pull/1866#issuecomment-2211676080
When the write operation fails and throws an exception, we need to make the `commitShuffle` fail as well. According to your current approach, the `commitShuffle` will succeed regardless of whether the write operation is successful or not, which makes `commitShuffle` meaningless. The purpose of `commitShuffle` is to ensure that all events are successfully written in sync, with no residual shuffle data left in memory, before starting the downstream read stage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
