rickyma commented on PR #1866:
URL:
https://github.com/apache/incubator-uniffle/pull/1866#issuecomment-2232240352
I think you haven't fully understood this issue. A flush event corresponds
to a specific `appId/shuffleId/partitionId`. If the event for this
`appId/shuffleId/partitionId` fails, then when committing the shuffle for this
specific shuffleId, it should fail too. Instead of using a global boolean value
`writeError` in `ShuffleFlushManager` to determine this, which would cause the
`commitShuffle` that does not belong to this `appId/shuffleId/partitionId` to
fail as well. We don't want this to happen.
For this issue, you'd better conduct some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
