xianjingfeng commented on code in PR #1870:
URL:
https://github.com/apache/incubator-uniffle/pull/1870#discussion_r1671734246
##########
dashboard/src/main/webapp/src/pages/serverstatus/NodeListPage.vue:
##########
@@ -132,14 +152,19 @@ export default {
const loadPageData = () => {
if (router.currentRoute.value.name === 'activeNodeList') {
+ isShowRemove.value = false
getShuffleActiveNodesPage()
} else if (router.currentRoute.value.name === 'decommissioningNodeList')
{
+ isShowRemove.value = false
getShuffleDecommissioningListPage()
} else if (router.currentRoute.value.name === 'decommissionedNodeList') {
+ isShowRemove.value = false
getShuffleDecommissionedListPage()
} else if (router.currentRoute.value.name === 'unhealthyNodeList') {
+ isShowRemove.value = false
getShuffleUnhealthyListPage()
} else if (router.currentRoute.value.name === 'lostNodeList') {
+ isShowRemove.value = true
getShuffleLostListPage()
}
Review Comment:
```suggestion
isShowRemove.value = false
if (router.currentRoute.value.name === 'activeNodeList') {
getShuffleActiveNodesPage()
} else if (router.currentRoute.value.name ===
'decommissioningNodeList') {
getShuffleDecommissioningListPage()
} else if (router.currentRoute.value.name ===
'decommissionedNodeList') {
getShuffleDecommissionedListPage()
} else if (router.currentRoute.value.name === 'unhealthyNodeList') {
getShuffleUnhealthyListPage()
} else if (router.currentRoute.value.name === 'lostNodeList') {
isShowRemove.value = true
getShuffleLostListPage()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
