xianjingfeng commented on code in PR #1870:
URL:
https://github.com/apache/incubator-uniffle/pull/1870#discussion_r1671728314
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -311,6 +312,21 @@ public List<ServerNode> list() {
return Lists.newArrayList(servers.values());
}
+ @Override
+ public boolean deleteLostServerById(String serverId) {
+ if (serverId != null && !serverId.equalsIgnoreCase("")) {
+ Iterator<ServerNode> lostNodeIter = lostNodes.iterator();
+ while (lostNodeIter.hasNext()) {
+ ServerNode node = lostNodeIter.next();
+ if (serverId.equalsIgnoreCase(node.getId())) {
+ lostNodes.remove(node);
+ return true;
+ }
+ }
+ }
Review Comment:
```suggestion
if (StringUtils.isNotBlank(serverId)) {
lostNodes.remove(new ServerNode(serverId));
}
```
Maybe this works, you can try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
