leixm commented on code in PR #1940:
URL:
https://github.com/apache/incubator-uniffle/pull/1940#discussion_r1685882460
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcNettyClient.java:
##########
@@ -166,7 +166,15 @@ public RssSendShuffleDataResponse
sendShuffleData(RssSendShuffleDataRequest requ
0L,
stb.getValue(),
System.currentTimeMillis());
- int allocateSize = size + sendShuffleDataRequest.encodedLength();
+ // headerEncodedLength = messageEncodedLength + messageTypeEncodedLength
+ bodyLength +
+ // messageEncodedLength
+ // {@link org.apache.uniffle.common.netty.MessageEncoder#encode}
+ int headerEncodedLength =
Review Comment:
I think we need a static variable to represent the 9 bytes of the header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
