zuston commented on code in PR #1940:
URL:
https://github.com/apache/incubator-uniffle/pull/1940#discussion_r1687383666
##########
common/src/main/java/org/apache/uniffle/common/ShuffleBlockInfo.java:
##########
@@ -95,10 +95,17 @@ public int getLength() {
return length;
}
- // calculate the data size for this block in memory including metadata which
are
- // partitionId, blockId, crc, taskAttemptId, length, uncompressLength
+ /**
+ * Calculate the data size for this block in memory including metadata which
are partitionId,
+ * blockId, crc, taskAttemptId, uncompressLength and data length. This
should be consistent with
+ * {@link ShufflePartitionedBlock#getSize()}.
+ *
+ * @return the encoded size of this object in memory
+ */
public int getSize() {
- return length + 3 * 8 + 2 * 4;
+ // FIXME(maobaolong): The size is calculated based on the Protobuf message
ShuffleBlock.
+ // If Netty's custom serialization is used, the calculation logic here
needs to be modified.
Review Comment:
Do you mean netty still use the protobuf de/serialization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
