zuston commented on code in PR #1958:
URL: 
https://github.com/apache/incubator-uniffle/pull/1958#discussion_r1692572425


##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -636,6 +636,12 @@ public class ShuffleServerConf extends RssBaseConf {
               "A comma-separated block size list, where each value"
                   + " can be suffixed with a memory size unit, such as kb or 
k, mb or m, etc.");
 
+  public static final ConfigOption<Long> 
STORAGE_REMOVE_RESOURCE_OPERATION_TIMEOUT_SEC =
+      ConfigOptions.key("rss.server.storage.resourceRemoveOperationTimeoutSec")
+          .longType()
+          .defaultValue(10 * 60L)

Review Comment:
   Yep. This is another option to set the default value.
   
   Aha, I haven't noticed this util class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to