maobaolong commented on code in PR #1958:
URL:
https://github.com/apache/incubator-uniffle/pull/1958#discussion_r1692576578
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -811,12 +829,21 @@ public void removeResources(String appId, boolean
checkAppExpired) {
partitionsToBlockIds.remove(appId);
shuffleBufferManager.removeBuffer(appId);
shuffleFlushManager.removeResources(appId);
- storageManager.removeResources(
- new AppPurgeEvent(
- appId,
- shuffleTaskInfo.getUser(),
- new ArrayList<>(shuffleTaskInfo.getShuffleIds()),
- checkAppExpired));
+
+ String operationMsg = String.format("removing storage data for
appId:%s", appId);
+ withTimeoutExecution(
Review Comment:
@zuston So do you think it is necessary to add a metrics for this? So that
we can be alerted and handle this exception by administrator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
