xianjingfeng commented on code in PR #1897:
URL:
https://github.com/apache/incubator-uniffle/pull/1897#discussion_r1698477135
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -179,15 +185,19 @@ public void nodesCheckTest() {
nodesCheck();
}
- private void updateExcludeNodes(String path) {
+ private synchronized void updateExcludeNodes(String path) {
int originalExcludeNodesNumber = excludeNodes.size();
try {
Path hadoopPath = new Path(path);
FileStatus fileStatus = hadoopFileSystem.getFileStatus(hadoopPath);
if (fileStatus != null && fileStatus.isFile()) {
long latestModificationTime = fileStatus.getModificationTime();
if (excludeLastModify.get() != latestModificationTime) {
- parseExcludeNodesFile(hadoopFileSystem.open(hadoopPath));
+ excludeNodes =
parseExcludeNodesFile(hadoopFileSystem.open(hadoopPath), true);
+ LOG.info(
+ "Updated exclude nodes and {} nodes were marked as exclude
nodes",
Review Comment:
@yl09099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
