xianjingfeng commented on code in PR #1897:
URL:
https://github.com/apache/incubator-uniffle/pull/1897#discussion_r1698521423
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -216,10 +222,52 @@ private void parseExcludeNodesFile(DataInputStream
fsDataInputStream) throws IOE
}
}
}
- // update exclude nodes and last modify time
- excludeNodes = nodes;
- LOG.info(
- "Updated exclude nodes and {} nodes were marked as exclude nodes",
excludeNodes.size());
+ return nodes;
+ }
+
+ private void writeExcludedNodes2File(List<String> excludedNodes) throws
IOException {
+ if (hadoopFileSystem == null) {
+ return;
+ }
+ Path hadoopPath = new Path(excludedNodesPath);
+ FileStatus fileStatus = hadoopFileSystem.getFileStatus(hadoopPath);
+ if (fileStatus != null && fileStatus.isFile()) {
+ String tempExcludedNodesPath = excludedNodesPath.concat("_tmp");
+ Path tmpHadoopPath = new Path(tempExcludedNodesPath);
+ if (!hadoopFileSystem.exists(tmpHadoopPath)) {
+ hadoopFileSystem.create(tmpHadoopPath);
+ }
Review Comment:
```suggestion
if (hadoopFileSystem.exists(tmpHadoopPath)) {
hadoopFileSystem.delete(tmpHadoopPath);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
