maobaolong commented on code in PR #1991:
URL:
https://github.com/apache/incubator-uniffle/pull/1991#discussion_r1701236903
##########
pom.xml:
##########
@@ -83,7 +83,7 @@
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<spotless-maven-plugin.version>2.30.0</spotless-maven-plugin.version>
- <metrics.version>3.1.0</metrics.version>
+ <metrics.version>3.1.2</metrics.version>
Review Comment:
As you change to use
`<prometheus.simpleclient.version>0.9.0</prometheus.simpleclient.version>` for
the version of `io.prometheus:simpleclient_dropwizard` now, can you try to
build again without `metrics.version` change and check whether the enforcing
error exists? If not, you can paste the new log part here again.
##########
pom.xml:
##########
@@ -83,7 +83,7 @@
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<spotless-maven-plugin.version>2.30.0</spotless-maven-plugin.version>
- <metrics.version>3.1.0</metrics.version>
+ <metrics.version>3.1.2</metrics.version>
Review Comment:
@kuszz As you change to use
`<prometheus.simpleclient.version>0.9.0</prometheus.simpleclient.version>` for
the version of `io.prometheus:simpleclient_dropwizard` now, can you try to
build again without `metrics.version` change and check whether the enforcing
error exists? If not, you can paste the new log part here again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
