advancedxy commented on PR #1991: URL: https://github.com/apache/incubator-uniffle/pull/1991#issuecomment-2268522181
> > 1. how will this new metrics system integrate with existing systems? I think a lot of people are already using prometheus to collect metrics data. It would be great if we can make a drop-in replacement for that. cc @xianjingfeng maybe you have some input about this part > > This PR does not affect the original collection logic. https://www.robustperception.io/exposing-dropwizard-metrics-to-prometheus/ This is good to know. But it seems it doesn't support labels? Or it could be supported in another way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
