maobaolong opened a new pull request, #2007:
URL: https://github.com/apache/incubator-uniffle/pull/2007
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Add return value for server rpc audit log
### Why are the changes needed?
With the return value, we can know clear about the effect of the rpc call.
E.g. A bundle of `requireBuffer` calls appear in the rpc audit log, then
followed some `sendShuffleData` rpc call with `requireBufferId`, but we don't
know which `requireBuffer` call match the sendShuffleData call.
With this PR, we record the requireBufferId also which generated by
`requireBuffer` call, and search the sendShuffleData call with the
`requireBufferId`, this can be possible.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Test Locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]