jerqi commented on code in PR #2007:
URL:
https://github.com/apache/incubator-uniffle/pull/2007#discussion_r1710690102
##########
server/src/main/java/org/apache/uniffle/server/audit/ServerRPCAuditContext.java:
##########
@@ -122,4 +126,9 @@ public ServerRPCAuditContext setArgs(String args) {
this.args = args;
return this;
}
+
+ public ServerRPCAuditContext setReturnValue(String returnValue) {
Review Comment:
Could we change `setReturnValue` to `withReturenValue`. I feel the setter
should return void instead of a object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
