kuszz commented on code in PR #1991:
URL:
https://github.com/apache/incubator-uniffle/pull/1991#discussion_r1704831520
##########
common/src/main/java/org/apache/uniffle/common/metrics/MetricsManager.java:
##########
@@ -66,14 +75,43 @@ public Counter.Child addLabeledCounter(String name) {
return c.labels(this.defaultLabelValues);
}
+ @Deprecated
Review Comment:
I removed the annotation, the new way can not add labels, so it cannot
completely replace the old method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
