maobaolong commented on PR #2022: URL: https://github.com/apache/incubator-uniffle/pull/2022#issuecomment-2274836388
@xianjingfeng I suppose to abstract a new module `server-common` by https://github.com/apache/incubator-uniffle/pull/1884 aimed to reduce the client fat jar size. If we move rest-client from cli to common, the uniffle client fat jar would be greater than before although the shaded rss spark client never use the rest-client? So we can move the `rest-client` to `server-common`, and all server-side modules can use `server-common` as dependency, and rss-client can avoid introduce the extra unnecessary dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
