advancedxy commented on code in PR #2022:
URL:
https://github.com/apache/incubator-uniffle/pull/2022#discussion_r1708758500
##########
common/pom.xml:
##########
@@ -174,6 +174,14 @@
<groupId>org.apache.hbase.thirdparty</groupId>
<artifactId>hbase-shaded-jersey</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
Review Comment:
hmmm.
IIUC, it's just added in
https://github.com/apache/incubator-uniffle/pull/1999, I think this kind of
change might need more eyes.
It might worthwhile to use lombok in the web development, I don't think it's
good practice to use this lib everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
