lifeSo commented on PR #2135:
URL:
https://github.com/apache/incubator-uniffle/pull/2135#issuecomment-2372879441
> ```shell
> version=$($RUNNER -version 2>&1 | awk -F[\".] '/version/ {print $2}')
> if [[ "$version" -lt "9" ]]; then
> COORDINATOR_JVM_GC_ARGS="${COORDINATOR_JVM_GC_ARGS:-${DEFAULT_GC_ARGS}
${GC_LOG_ARGS_LEGACY}}"
> else
> COORDINATOR_JVM_GC_ARGS="${COORDINATOR_JVM_GC_ARGS:-${DEFAULT_GC_ARGS}
${GC_LOG_ARGS_NEW}}"
> fi
> ```
>
> Reference this above shell script, I try to use `COORDINATOR_JVM_GC_ARGS`
first, but I found that if I customized `COORDINATOR_JVM_GC_ARGS`, I lost
`$GC_LOG_ARGS_LEGACY` or `GC_LOG_ARGS_NEW` too, so I have to define
`GC_LOG_ARGS_LEGACY` or `GC_LOG_ARGS_NEW` to `rss-env.sh` also, unfortunately,
I found these two need another env var `RSS_LOG_DIR` which is not set value in
`rss-env.sh`, so I have no idea with this way.
>
> ```shell
> GC_LOG_ARGS_LEGACY=" -XX:+PrintGC \
> -XX:+PrintAdaptiveSizePolicy \
> -XX:+PrintGCDateStamps \
> -XX:+PrintGCTimeStamps \
> -XX:+PrintTenuringDistribution \
> -XX:+PrintPromotionFailure \
> -XX:+PrintGCApplicationStoppedTime \
> -XX:+PrintGCCause \
> -XX:+PrintGCDetails \
> -Xloggc:${RSS_LOG_DIR}/gc-%t.log"
>
> GC_LOG_ARGS_NEW=" -XX:+IgnoreUnrecognizedVMOptions \
> -Xlog:gc* \
> -Xlog:gc+age=trace \
> -Xlog:gc+heap=debug \
> -Xlog:gc+promotion=trace \
> -Xlog:gc+phases=debug \
> -Xlog:gc+ref=debug \
> -Xlog:gc+start=debug \
> -Xlog:gc*:file=${RSS_LOG_DIR}/gc-%t.log:tags,uptime,time,level"
> ```
>
> So, I have to do this change to support customize gc related arguments to
different value for different machine type of cluster.
I don't understand.
How about direct modify start-coordinator.sh or start-shuffle-server.sh when
want to custom jvm config.
I think keep it simple is best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
