advancedxy commented on PR #2135: URL: https://github.com/apache/incubator-uniffle/pull/2135#issuecomment-2375603498
> @lifeSo Thanks for your reply, as I did a serial of efforts around `scripts` and `config`, the motivation is that decouple `scripts` and `config`, finally, user and operation administrator should never have to modify the files out of `config`. > > We use git repository to maintain the source code(include java code and scripts), but use config center service to maintain the config(include jvm configs) for different cluster. To me, I think it might make sense to slightly change the script and upgrade your service with that new script. Anyway, it's also reasonable to configure it totally by environment variables. @lifeSo Do you have any other concerns or comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
