maobaolong commented on code in PR #2124: URL: https://github.com/apache/incubator-uniffle/pull/2124#discussion_r1776585085
########## server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBuffer.java: ########## @@ -53,7 +53,7 @@ ShuffleDataResult getShuffleData( long getSize(); /** Only for test */ - List<ShufflePartitionedBlock> getBlocks(); + Set<ShufflePartitionedBlock> getBlocks(); Review Comment: @zhengchenyu @lwllvyb Do you think this could cause memory leak? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
