maobaolong commented on code in PR #2124:
URL:
https://github.com/apache/incubator-uniffle/pull/2124#discussion_r1776589087
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferWithLinkedList.java:
##########
@@ -39,11 +41,11 @@ public class ShuffleBufferWithLinkedList extends
AbstractShuffleBuffer {
// blocks will be added to inFlushBlockMap as <eventId, blocks> pair
// it will be removed after flush to storage
// the strategy ensure that shuffle is in memory or storage
- private List<ShufflePartitionedBlock> blocks;
- private Map<Long, List<ShufflePartitionedBlock>> inFlushBlockMap;
+ private Set<ShufflePartitionedBlock> blocks;
Review Comment:
@zhengchenyu @lwllvyb Do you think this could cause memory leak?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
