EnricoMi commented on code in PR #2189:
URL:
https://github.com/apache/incubator-uniffle/pull/2189#discussion_r1802442627
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -922,7 +922,7 @@ public void sendAppHeartbeat(String appId, long timeoutMs) {
}
return null;
},
- timeoutMs,
+ timeoutMs * allShuffleServers.size() / heartBeatThreadNum + 100,
Review Comment:
Please make sure the individual request itself respects the timeout, like in
https://github.com/apache/incubator-uniffle/pull/1738/files#diff-4772b95a6a13de40473a9a99cef322eec20df14a4c19182eff997272427154dbR367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
