xumanbu commented on code in PR #2189:
URL:
https://github.com/apache/incubator-uniffle/pull/2189#discussion_r1806100839
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -922,7 +922,7 @@ public void sendAppHeartbeat(String appId, long timeoutMs) {
}
return null;
},
- timeoutMs,
+ timeoutMs * allShuffleServers.size() / heartBeatThreadNum + 100,
Review Comment:
> The 100 looks a bit arbitrary. In the worst case scenario where all
requests timeout those extra 100ms won't give any extra benefit.
agree with u. the 100ms is just a minor buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
